Tran Nguyen
1.What project are you working on?
Extension framework testing
2. What you accomplished this week.
Discuss with Christian what needs to be done, start looking at extension
manager, install rbtmod extension and trace point
3. Links to anything you’ve done week:
Nothing new except the two pending CR
https://reviews.reviewboard.org/r/6879/
https://reviews.reviewboard.org/r/7066/
4. What you plan to do next week.
Gather the remaining knowledge to start implementing extension testing
framework
5. What, if anything, is blocking you from making progress?
Nothing yet, I will ask on Slack.
6. Any other questions.
Nope.
Teresa Fan
1.What project are you working on?
Interactive Issue Summaries
2.What you accomplished this week.
Finally fixed my bug so that now issue statuses update in both places correctly regardless of where you update them.
Wrote tests for this.
3.Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra
4.What you plan to do next week.
Next steps originally included adding a link with the number of replies that brought you to the comment, but maybe that’s not necessary anymore since we have the ‘See comment’ link. I also thought about making the cell expand on hover instead of click.
5.What, if anything, is blocking you from making progress?
If anyone could review my code that’d be great!
6.Any other questions.
Asking in Slack about git problems. See #4 for questions about what would be best to do next.
Rohan Meringenti
1.What project are you working on?
Revokable Ship it Labels
2.What you accomplished this week.
Finallly fixed my bug with the event listeners. You can now see the changes immediately on the page. Furthermore, the ship it counter has also been updated for the review request.
3.Links to anything you’ve done week
https://reviews.reviewboard.org/r/7170/
4.What you plan to do next week.
Finish style, add tests. and pick a new task
5.What, if anything, is blocking you from making progress?
If someone could look at my WIP that would be great. All the big changes are already there, I just have to add style and tests now.
6.Any other questions.
Nope
Chen Feng
1.What project are you working on?
Create a new plugin.
2.What you accomplished this week.
reset my environment, and fixed a bug.
3.Links to anything you’ve done week
https://reviews.reviewboard.org/r/7191/
https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd
4.What you plan to do next week.
Download Review Bot. Write my project.
5.What, if anything, is blocking you from making progress?
NO
6.Any other questions.
No~ if have, I’ll ask it in slack.
Sihang Chen
- What project are you working on?
Add unreviewed section to dashboard.
- What you accomplished this week.
Accomplish the function to show the unreviewed review requests, and the count number of outgoing unreviewed review requests, but still not many tests.
- Links to anything you’ve done week
hackpad: https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy
reviewboard_reviewrequests: https://reviews.reviewboard.org/r/7193/
- What you plan to do next week.
Continue working on the incoming count number.
- What, if anything, is blocking you from making progress?
School work of my own.
- Any other questions.
Not yet, but please review my review requests at the link above, thank you so much ^_^.
Chen Mingyi
- What project are you working on?
Add infinite scrolling to the diff viewer
Read-only site mode
- What you accomplished this week.
Fix issues and start a new project.
- Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY
- What you plan to do next week.
To stop some actions.
- What, if anything, is blocking you from making progress?
How many functions do review board have, and how many should be stopped.
- Any other questions.
The previous project is still waiting for review!
Chenxi Ni
1) What project are you working on?
OAuth2 provider support
2) What you accomplished this week.
looking into how OAuth2 works and follow the tutorial and try
3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My RR for my first project: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP
4) What you plan to do next week.
according to the tutorial to list what should be done and write more basic code.
5) What, if anything, is blocking you from making progress?
No.
6) Any other questions
Not yet.
Sun Wang Jun
- What project are you working on?
Checklist extension (templates)
- What you accomplished this week.
Refactored the checklist code base and updated the review request
- Links to anything you’ve done week
https://reviews.reviewboard.org/r/7176/
- What you plan to do next week.
Code the ui for templates
- What, if anything, is blocking you from making progress?
School projects
- Any other questions.
No
Stanley Yeo
- What project are you working on?
Improve Review Bot’s admin interface
Auto-add users to groups
- What you accomplished this week.
Wrote some documentation.
Test functionalities.
Update RR.
- Links to anything you’ve done week
https://reviews.reviewboard.org/r/7176/
- What you plan to do next week.
https://reviews.reviewboard.org/r/7165/
- What, if anything, is blocking you from making progress?
None
- Any other questions.
Please review 6998, 6999, 7165
Xuanyi
- What project are you working on?
Framework and UI for integrating with third-party services
- What you accomplished this week.
Update review request
Implement basic RBslack with integration.
- Links to anything you’ve done week
https://reviews.reviewboard.org/r/7105/
https://reviews.reviewboard.org/r/7136/
- What you plan to do next week.
Continue to work on integration form and rbslack with integration
- What, if anything, is blocking you from making progress?
Some questions on one of my review: https://reviews.reviewboard.org/r/6918/
School projects.
- Any other questions.
The rbslack integration could potentially be use to target specific group/user. However, will it be possible for subclass of SiteSettingForm to support autocomplete?
Jifei Wen
1. What project are you working on?
reviewbot plugin PEP257 and shellcheck
2. What you accomplished this week.
PEP257: fix bug and modify docstring shellcheck: write it
3. Links to anything you’ve done week:
https://reviews.reviewboard.org/r/7101/
https://reviews.reviewboard.org/r/7197/
4. What you plan to do next week.
modify both plugins
5. What, if anything, is blocking you from making progress?
no, i will ask at slack or reviews
6. Any other questions.
No.
Wu Di
1. What project are you working on?
Allow replying to reviews from the diffviewer
2. What you accomplished this week.
Got the updating of draft review replies and making new review replies to work properly.
Added in styling for the review reply editor.
3. Links to anything you’ve done week:
https://reviews.reviewboard.org/r/7172/
4. What you plan to do next week.
Continue working on getting the comment blocks to update its serialized comments upon adding or updating replies.
5. What, if anything, is blocking you from making progress?
Would appreciate feedback on the current UI. (https://reviews.reviewboard.org/r/7172/file/891/)
Also, some reviews for my other two review request would be nice, https://reviews.reviewboard.org/r/6970 and https://reviews.reviewboard.org/r/7032.
I will be busy with my other school projects this week.
- Any other questions.
Is there a good way to publish the review reply from the diffviewer? Christian suggested a while back to have a banner at the top of the page, similar to the draft review banner, but that would be confusing.
Or is it even a good idea to allow publishing/discarding of review replies in the diffviewer when the other replies of the review reply cannot be seen?
For example, you have an incomplete body top reply along with a diff comment reply, publishing the review reply will make both replies public, which is bad.
I think it isn’t very obvious that review replies are basically reviews where you make a bunch of replies to the body top/diff/file attachment comments of another review, this might cause users to publish a review reply thinking that they are only publishing one diff comment reply instead of all the other replies in the review reply.
Jessica Qian
1.What project are you working on?
“Trivial” reviews
2. What you accomplished this week.
I was working a poster presentation for this class.
3. Links to anything you’ve done week:
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem
https://reviews.reviewboard.org/r/7022/
https://reviews.reviewboard.org/r/7022/
4. What you plan to do next week.
I need to clarify the UI details for trivial reviews.
Respond to RR for trivial review requests.
5. What, if anything, is blocking you from making progress?
None.